chore: minor updates for build system improvements #19784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
commented
Jun 11, 2024
andrwng
approved these changes
Jun 11, 2024
andrwng
approved these changes
Jun 11, 2024
std::btree_set in newer abseil returns const iterators (like std::set - https://en.cppreference.com/w/cpp/container/set/begin). the rationale for this is that the container is indexing a T but the compiler can't determine which parts of T are used in the comparison function, so it stays conservative. i manually looked and it seemed as tho the end field was never involved in comparisons, so this is probably safe. but btree_map would probably be clearer where you put the mutable parts in the value. we could also remove and then re-insert to make compiler happy. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Makes for finer grained libraries in the bazel build. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
|
new failures in https://buildkite.com/redpanda/redpanda/builds/50135#01900a26-8398-47f2-b23d-34e875f14428: new failures in https://buildkite.com/redpanda/redpanda/builds/50141#01900ad8-c82c-4f3a-b1b9-bd453d4c3d48: |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50141#01900ad7-fdca-4350-9dec-b4ed558400e0 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/50141#01900ad8-c827-494a-bd05-609436883962 |
|
Failure was #19632 which was fixed an hour ago, but we missed the cut-off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes